Task: Fix build to run with linters

Question

Task: Fix build to run with linters

jbolster opened this issue 8 years ago · comments

Jonathon Bolster commented 8 years ago

Currently grunt --force needs to be runin order to pass the linting.

SASS/HTML/JS files all have issues at the moment.

When complete, ensure that travis config isn't running with --force

Dan Atkinson · Answer 1 · Mon Dec 19 2016 05:37:29 GMT+0800 (China Standard Time)

Hi Jonny,

Did you commit the gruntfile? I can't see any commits for it.

Thanks, Dan

Jonathon Bolster · Answer 2 · Mon Dec 19 2016 05:42:30 GMT+0800 (China Standard Time)

It's in this pull-request: https://github.com/DanAtkinson/Fuskr/pull/27/files

Dan Atkinson · Answer 3 · Mon Dec 19 2016 05:43:31 GMT+0800 (China Standard Time)

Ah, okay. You can accept your own pull requests on this repo. :-)

Edit: Merged. :-)

Dan Atkinson · Answer 4 · Mon Dec 19 2016 06:02:50 GMT+0800 (China Standard Time)

Hi @jbolster,

I don't know if it helps or not, but I use Brackets which includes jslint when editing. Be sure to install an extension like "mitchellsimoens.file-tree-exclude" which will ignore large folders like node_modules and bower_modules.

Thanks, Dan

Jonathon Bolster · Answer 5 · Mon Dec 19 2016 07:18:37 GMT+0800 (China Standard Time)

:) Yeah, I still think it's good for a thumbs up. I'll just merge ALL THE THINGS next time ;)

I use Atom with all the linters and that picks up on the config files that I've checked in (as does the grunt tasks). It also ignores everything that's in the .gitignore file.

Sadly, most of the code here is pre-Atom-usage so needs to be poked in some form or another. Currently refactoring the JS out so that'll fix a lot during that process.