[NOT AN ISSUE] This "theme" could have been an extension instead..
AvinashReddy3108 opened this issue · comments
That way, the user can easily use your CSS rules to block ads in whatever theme they install..
As a proof-of-concept, I have cloned Charlie's extension (the one you use the adblock.js
from) and simply added your user.css
to it.
Here's my repo: https://github.com/AvinashReddy3108/spicetify-extension-subsidized
Heck, even Charlie's adblock.js
contains the CSS rules of NoPremium now..
Commit: CharlieS1103/spicetify-extensions@48ef81d
Hey @AvinashReddy3108, I'm really sorry but I somehow missed your issue and didn't see it.
I understand that this theme could be an extension, however, some of the CSS rules in my theme conflicts with some other themes so I'm not sure if we should go ahead with it. What do you think?
..... however, some of the CSS rules in my theme conflicts with some other themes so I'm not sure if we should go ahead with it. What do you think?
- I did not know about the conflicts with the themes, I tried a bunch of popular ones (injected CSS using modified
adblock.js
) and it played nice.. - I won't hold it against you if you decide not to go ahead with my suggestion :)
- [Worth a try?] Splitting this "theme" into 2 "extensions" (one with bare minimum ad-blocking focused JS/CSS + other one with the accessibility CSS rules)
Seems like Charlie is already doing the same, hahaha.
You have a good point but I guess I'll just let it be as is for now and not cause any extra confusion to the existing users of this theme.