How readNWISSample() handles records where concentration is stored as exactly 0.0

Question

How readNWISSample() handles records where concentration is stored as exactly 0.0

rmhirsch49 opened this issue 10 months ago · comments

In the past, as I remember it, when one ran readNWISSample() and the data set contained a concentration value that was coded as exactly 0.0, the function would go ahead and do the retrieval and also send a warning message saying that this happened and that the offending values were left out of the Sample data frame that was created.

When I ran a job today I got an error message, and it never gave me the desired Sample data frame. I was able to see when the bad data point was and redo my retrieval and go ahead, but that seems less than ideal. Do you think I recall correctly how it was done. I would like to have it create the Sample data frame and tell the user that these zeros were deleted.

Try this example

library(EGRET)
staC <- "01646580"
staQ <- "01646500"
param <- "00665"
Sample <- readNWISSample(staC, param)

Then I did it again with a start date of 1980-06-01 and it worked fine (except that I couldn't get any data from before that date)

Bob

Laura DeCicco · Answer 1 · Mon Oct 16 2023 23:56:21 GMT+0800 (China Standard Time)

I think I see the issue and should have a fix up early this afternoon!

Laura DeCicco · Answer 2 · Tue Oct 17 2023 02:13:33 GMT+0800 (China Standard Time)

Try installing from GitHub and let me know if anything still is working incorrectly:

remotes::install_github("DOI-USGS/EGRET")

Laura Naslund · Answer 3 · Tue Oct 17 2023 04:57:24 GMT+0800 (China Standard Time)

I also ran into this issue. I tried installing from GitHub and I am still getting the same error.

Robert Hirsch · Answer 4 · Tue Oct 17 2023 05:09:49 GMT+0800 (China Standard Time)

It worked fine for me. It found one bad data point with concentration coded as 0.0, it gave me a warning, left that one value out of the Sample data frame, but did construct the Sample data frame as desired. My code was: # note, this was done after install from GITHUB at 5:04 EDT, October 16 library(EGRET) staC <- "01646580" staQ <- "01646500" param <- "00665" Sample <- readNWISSample(staC, param, startDate = "1970-06-01") summary(Sample) It ran and gave me this warning message, which looks like the warning messages I got in the past when the zero problem came up. 2: In compressData(rawSample[, totalColumns], verbose = verbose) : Deleted 1 rows of data because concentration was reported as 0.0, the program is unable to interpret that result and is therefore deleting it. So, from my perspective the problem seems to be solved. Thanks Laura. From: Laura DeCicco ***@***.***> Date: Monday, October 16, 2023 at 2:14 PM To: DOI-USGS/EGRET ***@***.***> Cc: Hirsch, Robert M ***@***.***>, Author ***@***.***> Subject: [EXTERNAL] Re: [DOI-USGS/EGRET] How readNWISSample() handles records where concentration is stored as exactly 0.0 (Issue #373) This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding. Try installing from GitHub and let me know if anything still is working incorrectly: remotes::install_github("DOI-USGS/EGRET") — Reply to this email directly, view it on GitHub<#373 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAI53UPHSIA3WLJ7X6SFFZDX7V2NRAVCNFSM6AAAAAA6AM7RHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRVGAZTONZYGY>. You are receiving this because you authored the thread.Message ID: ***@***.***>

Laura DeCicco · Answer 5 · Tue Oct 17 2023 20:16:58 GMT+0800 (China Standard Time)

@lnaslund , could you paste the code you used to see the error again? Or let me know the site ID? While you are at it, paste your session info so I can try to tell if it's a dependency problem or your particular site has something funky going on:

library(EGRET)
sessionInfo()

Laura Naslund · Answer 6 · Mon Oct 23 2023 20:06:42 GMT+0800 (China Standard Time)

Apologies for the delay. The issue appears to be resolved. Thank you.