Giters

DOI-USGS / EGRET

An R-package for the analysis of long-term changes in water quality and streamflow, including the water-quality method Weighted Regressions on Time, Discharge, and Season (WRTDS). https://doi-usgs.github.io/EGRET/

Home Page:http://doi-usgs.github.io/EGRET/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

One more fix needed to setupYears

rmhirsch49 opened this issue · comments

commented

Laura: I was digging into your new version of setupYears because of some other stuff I was doing. I think there is an error in one line of code. Please see if I'm right. The line should say:

numDaysInYear <- as.numeric(lastDate - firstDay_i + 1)

Without this change I was finding that full years (non leap year) had numDaysInYear were 364. But please check it over to make sure it is correct. Thanks. Bob

commented

I just fixed this and pushed it up to the main "USGS-R/EGRET" repo, so installing like this:

remotes::install_github("USGS-R/EGRET")

will get the new setupYears code.