DFO-CHS-Dynamic-Hydrographic-Products / IWLS_pygeoapi

pygeoapi plugins to access and process water level and surface currents from the IWLS public API

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update S100 file creation code and production templates for S-111 1.2.1 and S-104 1.1.0

maximecarre1 opened this issue · comments

The following changes in the latest version of the draft specs will need to be implemented:

-typeOfWaterLevelData and typeOfSurfaceCurrentData are now named dataDynamicity and the attribute is common between the two specs.
-verticalCoordinateBase is being removed from S111, seaSurface can now be set with verticalDatum
-verticalDatum enum as new possible values (seaSurface and seaFloor)
-new format for the horizontalCRS
-new optional metadata values for stations group (we might be able to populate some of them from the IWLS metadata):
• Location Maritime Resource Name
• URL to station or data portal
• Type of Tide
• Station type

We will need to wait for the final version of the specs to implement changes.

commented

Thanks @maximecarre1 for that. We will discuss tomorrow about the best strategy to keep track of the different specs versions in relation to the code versions:

  • Always ensure backwards compatibility of the new code versions with at least the last two versions of the specs?
  • Associate specific code versions tags with a list of specific specs?
  • Some other strategy?