[node identifier] connId, memberId, address
AgwaB opened this issue · comments
now we manage member
with MemberId
and Address
type MemberId = string
type Address struct {
Ip string
Port uint16
}
type Member struct {
Id MemberId
Addr Address
}
And connection has ConnId
type ConnId = string
I think MemberId
and ConnId
are very confusing in using.
So, i suggest we use MemberId
and ConnId
as same thing but leave to divide meaning.
MemberId
: identifier of members (include myself)
ConnId
: identifier of connections (don't include myself)
etc)
RBC
needs identifier of proposer
(who propose the consensus first). pb.message.RBC
needs proposer's identifier and i think it maybe address
of proposer node.
So, i suggest modifying memberMap can search member also with Address