Use number server to lookup DCLP files
Edelweiss opened this issue · comments
Make use of the number server when calling up dclp records
./app//controllers/publications_controller.rb:101: if !(/papyri\.info\/dclp/ =~ identifier) # cromulent dclp hack to circumvent number server
./app//models/dclp_meta_identifier.rb:60: # cl: CROMULENT DCLP ‘View in PN’ hack
./app//models/dclp_text_identifier.rb:18: # cl: CROMULENT DCLP ‘View in PN’ hack
./app//models/dclp_text_identifier.rb:148: # cl: CROMULENT DCLP ‘View in PN’ hack
Get Catalog Link
- https://github.com/DCLP/sosol/blob/development/app/views/identifiers/_pn_link.haml#L3
- https://github.com/DCLP/sosol/blob/development/app/models/dclp_meta_identifier.rb#L63
- https://github.com/DCLP/sosol/blob/development/app/models/dclp_text_identifier.rb#L20
- https://github.com/DCLP/sosol/blob/development/app/models/identifier.rb#L535
With the number server working for DCLP, ddb files and hgv files get picked up alonside translations when calling up a DCLP file in the editor (see pink box):
This behaviour needs to be changed so that only translations are picked up.
Change url of numbers server and xpath
https://github.com/DCLP/sosol/tree/issue360
use numbers server for DCLP
https://github.com/DCLP/sosol/tree/issue346
good test case TM no. 129793 (DCLP file that has relations to DDB, HGV and HGV_trans)
When a translation is loaded alongside a DCLP record, the translation get the lead position (appearing in the title, being listed as the first item on the overview page, jumping automatically to the translations section after creation, see pink boxes)
merged to development and master
https://github.com/DCLP/sosol/tree/development
https://github.com/DCLP/sosol/tree/master
Can now be tested on DCLP test
can also be tested on production