CybroOdoo / CybroAddons

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Odoo 14 CE - Interaction between base_accounting_kit and the OCA account_reconciliation_widget. account_reconciliation_widget is showing blank cell_label state.st_line.payment_ref

whotopia opened this issue · comments

This Issue is same as OCA/account-reconcile#535 but being posted here as it seems to be caused by the CybroAddons/base_accounting_kit

Module

CybroAddons/base_accounting_kit and negative interaction with OCA account-reconcile/account_reconciliation_widget

Describe the bug

When the CybroAddons/base_accounting_kit is installed, the OCA account-reconcile/account_reconciliation_widget no longer works correctly.

Having a bank statement set up in Odoo 14 CE with many lines to reconcile, the statement shall have text for all lines in the payment_ref field "Label". Once the statement lines are posted, reconciling them within the account_reconciliation_widget one will notice a bug. There is no text in the grey field of the bank statement. The field, however, right before and after, the date and amount are correct.

This behaviour is consistent for me whenever I tried to use the reconciliation widget. The account_reconciliation_widget works fine until you install the base_accounting_kit.

To Reproduce

Odoo 14 CE

Steps to reproduce the behaviour:

  1. In a clean CE ver 14 database, install the addon account_reconciliation_widget. Enable Full accounting features for the user.
  2. Create a bank statement with text in the Label (payment_ref) field along with anything else needed in order for the line to be valid. By the way, in my case, the Reference and Notes fields are typically blank.
  3. Go to the reconciliation widget after posting the statement lines. You will see that all the information needed to reconcile entries including preview of the text from the payment_ref field. Everything is working fine.
  4. Now install the CybroAddons base_accounting_kit .
  5. Go back to the bank account reconciliation widget after posting the statement lines. You will see that there is now no preview of the text from the payment_ref field.

Screenshot 2023-03-09 at 14 18 12

This is a bug.

Expected behaviour

For Odoo 14, the CybroAddons/base_accounting_kit offers its own reconciliation view which approaches Bank statement reconciliation via a perspective of reconcilable statement items (journal entries) devolved from the view in the bank statements page . This is described here https://www.cybrosys.com/blog/bank-reconciliation-process-in-odoo-14. I realise that I could leave out the account_reconciliation_widget and do reconciliation the Cybrosys way, however my accountant is more familiar with approaching reconciliation on a statement by statement basis.

The expected behavior would be that the features and functionalities of the CybroAddons/base_account_kit work, and that the inclusion of these features do not hamper or break other features provided by the OCA/account-reconcile addons. Specifically for the account_reconciliation_widget, this component and its namespace should be ensured to be preserved so that users can use its model and views AND also benefit from those provided by CybroAddons. The field in grey should contain whatever the text is from the bank statement line payment_ref. Instead it is blank.

Additional context

Running Odoo 14 CE with this addon. Using Python 3.8.13

I am also using multiple currencies and also the accounting addons from CybroSys, particularly the base_accounting_kit.

I have looked at account_reconciliation_widget/static/src/xml/account_reconciliation.xml and messed with the QWeb template a bit to see what's going on. But from what I can tell, the payment_ref field is empty when the view gets called. Somehow things are interacting here with whatever models the base_accounting_kit has.

 <td class="cell_label"><t
                                t-if="state.st_line.payment_ref"
                                t-esc="state.st_line.payment_ref"
                            /> <t t-if="state.st_line.amount_currency_str"> (<t
                                    t-esc="state.st_line.amount_currency_str"
                                />)</t></td>

In Odoo 13.0, the name for payment_ref is ref?

In payment_matching.py, try changing the ref to payment_ref here:

Screenshot_20230320-190918_Chrome

In Odoo 13.0, the name for payment_ref is ref?

In payment_matching.py, try changing the ref to payment_ref here:

Screenshot_20230320-190918_Chrome

Doesn't seem to have any impact. (I did reinstall / update the addon and restarted ) I also have this issue ( #251 ) related to the same set of files. It's bloody annoying. Perhaps connected?