cmake tree
svensht2 opened this issue · comments
I'd like to upstream cmake build support, how do I go about doing that?
Good point !
Consider adding a contrib/cmake directory.
CMakeFiles.txt and other cmake related resources should be there.
I don't seem to have enough permissions to create a topic branch on this repo, I can do a pull request from my fork. Traditionally the top level CMakeLists.txt is in the root directory and each subdirectory has its own corresponding CMakeLists.txt. Doing it all through a contrib/cmake tree will make the paths more convoluted. Your current Makefile build tree could live side by side with the CMake build tree.
I can do a pull request from my fork
Yes this will work
Your current Makefile build tree could live side by side with the CMake build tree.
The point is to make clear what is upstream supported and what is being contributed.
got it ,thanks for clarifying.
I didn't stumble upon it earlier, but it seems like your project at Facebook, zstd, is the evolution of this work. Do you recommend I transition to using that?
They are different in purpose.
FSE is an entropy layer, like Huffman or Arithmetic coders.
It can be combined with any kind of predictor.
Zstandard is an LZ compressor backed by an FSE entropy coder.
It's just one way to use FSE.
got it, thanks for clarifying.
I think LZ compressor backed by an FSE seems like the right thing for our streaming application.
closing the ticket.