sampling an empty array crashes

Question

Nodnarb12500 opened this issue a year ago · comments

defvar emptyArray (make-array 0)
(sample emptyArray)

hangs and very quickly takes all your ram.

Collin McKinley · Answer 1 · Thu May 18 2023 08:46:57 GMT+0800 (China Standard Time)

Hah, I never got around to fixing that I guess, I know at one point I was going to...

Brandon Suiter · Answer 2 · Fri May 19 2023 08:10:37 GMT+0800 (China Standard Time)

i relooked at my empty array test and found something else to be the cause

(defvar emptyArray (make-array 0)
(println (sample emptyArray))

i forgot a ')' on the defvar line

sample crashes with:
fish: Job 1, '~/Documents/GIT/crow/crow sampl…' terminated by signal SIGFPE (Floating point exception)

Collin McKinley · Answer 3 · Fri May 19 2023 08:14:29 GMT+0800 (China Standard Time)

Yeah its still broken though... I have a fix coming later tonight.