CrowdStrike / falconpy

The CrowdStrike Falcon SDK for Python

Home Page:https://www.falconpy.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[ BUG ] Uber Class command method keyword "action" collides with action parameter utilized by updatePolicyHostGroups operation.

jshcodes opened this issue · comments

Describe the bug
The Uber Class command method defines the initial argument that specifies the operation to perform as action. This value may be provided as a positional or keyword argument.

The updatePolicyHostGroups operation provided by the FileVantage service collection makes use of a parameter named action which will collide with the command method keyword when users leverage parameter abstraction.

To Reproduce

  • Construct an instance of the Uber Class (APIHarnessV2).
  • Call the updatePolicyHostGroups operation and specify assign or unassign for the action. Provide this value as a keyword, not as part of a parameters dictionary.
  • The action value will be lost and overridden with the Operation ID; updatePolicyHostGroups.

Expected behavior
The action parameter is respected when this operation is called from the Uber Class command method.

Environment (please complete the following information):

  • OS: All Supported
  • Python: All Supported
  • FalconPy: v1.3.1+

Additional context
Thanks go out to @Don-Swanson-Adobe for identifying and reporting this issue! 🙇