Large response body fails

Question

Large response body fails

varnerac opened this issue 4 years ago · comments

When returning a response over 65k bytes, Ace's HTTP2 service fails, with a timeout. We've verified locally with Mojito and Gun clients. I've added a reproducer here:

https://github.com/varnerac/Ace/tree/large_response_reproducer/

Andrew Varner commented 4 years ago

I did not

Andrew Varner · Answer 1 · Mon Mar 23 2020 12:09:36 GMT+0800 (China Standard Time)

Should clarify that the reproducing test is https://github.com/varnerac/Ace/blob/large_response_reproducer/test/ace/http2_test.exs#L277-L292

It relies on a change in the simple app here: https://github.com/varnerac/Ace/blob/large_response_reproducer/test/support.exs#L110

Peter Saxton · Answer 2 · Wed Apr 01 2020 17:04:52 GMT+0800 (China Standard Time)

Could you open a PR to add this test, even without the fix.

However instead of modifying simple app just make the greeting be an enormous binary https://github.com/varnerac/Ace/blob/large_response_reproducer/test/ace/http2_test.exs#L280

Charles · Answer 3 · Wed Jun 24 2020 19:58:35 GMT+0800 (China Standard Time)

Hi @varnerac could you eventually solve the large body issue?

I seem to be having same/similar issues downloading large files via ssl, same code worked fine on clear-text

Charles · Answer 4 · Sun Aug 23 2020 23:00:52 GMT+0800 (China Standard Time)

@varnerac Please see if this works for you #154

Andrew Varner · Answer 5 · Mon Aug 24 2020 00:02:42 GMT+0800 (China Standard Time)

@CharlesOkwuagwu I’ll try to look this evening. In the meantime, you could add the test from #151 to your PR as a test.