CosmicMind / Motion

A library used to create beautiful animations and transitions for iOS.

Home Page:http://cosmicmind.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Unbalanced calls to begin/end appearance

joergbirkhold opened this issue · comments

I got this message when presenting this Navigationcontroller.
"Unbalanced calls to begin/end appearance"
(The animation works as expected)

class AnimatableNavController: UINavigationController {

    var transtype:MotionTransitionAnimationType?
    
    open override func viewDidLoad() {
        super.viewDidLoad()
        isMotionEnabled = true
        motionTransitionType = transtype ?? .push(direction: .right)
        motionNavigationTransitionType = transtype ?? .push(direction: .right)
    }
}

Hey! I am sorry it took so long to get back to you. I don't recall seeing this. Please, if you still have any issues, let me know. Thank you!

So this bug is still present. For example, I have NavigationDrawer controller with ToolBarController as root view controller. Then I try to present modally SearchBarController, motion animation worked perfectly

let searchController = AppStoryboard.Tree.viewController(viewControllerClass: SearchViewController.self)
let searchBarController = SearchBarController(rootViewController: searchController)
searchBarController.isMotionEnabled = true
searchBarController.motionTransitionType = .autoReverse(presenting: .fade)
toolbarController?.present(searchBarController, animated: true)

But in log I see messages:

Unbalanced calls to begin/end appearance transitions for <Material.SearchBarController: 0x7f8db554bde0>.
Unbalanced calls to begin/end appearance transitions for <NavigationDrawerController: 0x7f8db680b000>.

Sorry for the delay too, but I also still see this.

I will see if I can replicate this issue. If you have a sample project that replicates this 100% of the time, I would appreciate it. Thank you for sharing the issue.

Hello @DanielDahan thank you for your fast reply. I have attached a sample project.

SampleMotion.zip

In this project current issue representing in 100% of the time.

@OrkhanAlikhanov Let's take a look at this.

This is now fixed in Motion 1.4.3. Thank you!

Thank you too! Great work!