Giters

Cosium / git-code-format-maven-plugin

A maven plugin that automatically deploys code formatters as pre-commit git hook

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update google java format to 1.15.0

valeriuvancea opened this issue · comments

commented

It would be nice to update the google java format version to 1.15.0, so there will be no need for the --add-exports

commented

@reda-alaoui

FYI: According to this comment on the google-java-format GitHub site, the --add-exports flags are no longer needed when invoking the CLI using java -jar, but they are still needed when using google-java-format as a library (which is the case for this plugin): Java 17 compatibility · Issue #612 · google/google-java-format

I don't use Java 17, so I haven't been able to verify this issue myself.

commented

Thanks for letting me know. The documentation change has to be reverted in this case.

commented

@reda-alaoui

I did a test to be sure and documented the results here. In summary, it will be best to revert the documentation change for the time being, as you suggested above.