Giters

ContractBridge / pbnj

A mavenized version of Tis Veugen's PbnJVeri application.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

PBNJ results not matching PbnJVeri results

folkengine opened this issue · comments

commented

The results being processed from the new pbnj project do not appear to be correct.

Examples:

Original library:

~/src/github.com/ContractBridge/PbnJVeri> java -jar PbnJVeri.jar correct_10.pbn
FilePosBegin[0] = 0
FilePosBegin[1] = 1406
FilePosBegin[2] = 2647
FilePosBegin[3] = 3108
FilePosBegin[4] = 4550
FilePosBegin[5] = 4954
FilePosBegin[6] = 5179
FilePosBegin[7] = 5389
FilePosBegin[8] = 5601
FilePosBegin[9] = 5725
FilePosBegin[10] = 5832
FilePosBegin[11] = 5939
FilePosBegin[12] = 6064
FilePosBegin[13] = 6189
FilePosBegin[14] = 6270
FilePosBegin[15] = 6352
FilePosBegin[16] = 6435
FilePosBegin[17] = 6526
FilePosBegin[18] = 6770
FilePosBegin[19] = 6887
FilePosBegin[20] = 7021
FilePosBegin[21] = 7173
FilePosBegin[22] = 7322
FilePosBegin[23] = 7442
FilePosBegin[24] = 8322
FilePosBegin[25] = 10307
FilePosBegin[26] = 10415
FilePosBegin[27] = 10571
FilePosBegin[28] = 10816
FilePosBegin[29] = 11011
FilePosBegin[30] = 11191
Total number of games read : 31
Import file is OK

New code:

~/src/github.com/ContractBridge/pbnj> java -jar build/libs/pbnj-2.9.2-RELEASE.jar src/test/resources/correct_10.pbn
FilePosBegin[0] = 0
Total number of games read : 1
Games with severe PBN error : 1
commented

correct_20.pbn matches:

java -jar build/libs/pbnj-2.9.2-RELEASE.jar src/test/resources/correct_20.pbn
FilePosBegin[0] = 0
FilePosBegin[1] = 840
FilePosBegin[2] = 1104
FilePosBegin[3] = 1368
FilePosBegin[4] = 1587
FilePosBegin[5] = 1792
FilePosBegin[6] = 1972
FilePosBegin[7] = 2178
FilePosBegin[8] = 2395
FilePosBegin[9] = 2613
FilePosBegin[10] = 2839
FilePosBegin[11] = 3023
FilePosBegin[12] = 3230
FilePosBegin[13] = 3451
FilePosBegin[14] = 3660
FilePosBegin[15] = 3887
FilePosBegin[16] = 5100
FilePosBegin[17] = 5175
FilePosBegin[18] = 5244
FilePosBegin[19] = 5456
FilePosBegin[20] = 5970
FilePosBegin[21] = 6096
FilePosBegin[22] = 6222
FilePosBegin[23] = 6355
FilePosBegin[24] = 7471
FilePosBegin[25] = 8625
FilePosBegin[26] = 8843
FilePosBegin[27] = 9110
FilePosBegin[28] = 9377
FilePosBegin[29] = 9598
FilePosBegin[30] = 9933
FilePosBegin[31] = 10173
FilePosBegin[32] = 10730
FilePosBegin[33] = 11215
FilePosBegin[34] = 11601
FilePosBegin[35] = 12005
FilePosBegin[36] = 12494
FilePosBegin[37] = 12862
FilePosBegin[38] = 13200
FilePosBegin[39] = 13573
FilePosBegin[40] = 13888
FilePosBegin[41] = 14248
FilePosBegin[42] = 14588
FilePosBegin[43] = 14890
FilePosBegin[44] = 15237
FilePosBegin[45] = 17041
Total number of games read : 46
Games with severe PBN error : 9
Games with PBN error : 20
Games with PBN warning : 5
commented

Doesn't match on correct_21.pbn

pbnj:

java -jar build/libs/pbnj-2.9.2-RELEASE.jar src/test/resources/correct_21.pbn
FilePosBegin[0] = 0
Total number of games read : 1
Games with severe PBN error : 1

PbnJVeri:

java -jar PbnJVeri.jar correct_21.pbn
FilePosBegin[0] = 0
FilePosBegin[1] = 843
Total number of games read : 2
Games with PBN error : 2
commented

I'm diving into this one. Gonna see if I can get a hook into the code through the debugger.