FSL bug: mcpp dependencies can be parsed incorrectly
ivalylo opened this issue · comments
Hello,
When you have compiled the FSL files and try to run again, the check for file stamps produces error:
1> File "C:\postal\The-Forge\Tools\ForgeShadingLanguage\VS\/fsl_vs_call_helper.py", line 36, in <module>
1> sys.exit(main())
1> File "C:\postal\The-Forge\Tools\ForgeShadingLanguage\fsl.py", line 74, in main
1> if not needs_regen(args, dependency_filepath, platforms, regen, dependencies):
1> File "C:\postal\The-Forge\Tools\ForgeShadingLanguage\utils.py", line 600, in needs_regen
1> deps_timestamp = max([os.path.getmtime(filepath.strip()) for filepath in files])
1> File "C:\postal\The-Forge\Tools\ForgeShadingLanguage\utils.py", line 600, in <listcomp>
1> deps_timestamp = max([os.path.getmtime(filepath.strip()) for filepath in files])
1> File "genericpath.py", line 55, in getmtime
1>OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: 'C:/postal/Postal/Shaders/shader_defs.h C:/postal/Postal/Shaders/packing.h'```
I tracked the issue to utils.py, where it assumes that mcpp will write each include name on different line. However, if the filenames are short enough, they are on the same line.
Thanks for bringing this to our attention. It will be fixed in the next release.
Fixed with the latest release