ComputationalRadiationPhysics / spack-repo

spack.io repo for our in-development packages

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Adapting to alpaka's new CMake installation routines

j-stephan opened this issue · comments

I am currently working on the spack module for alpaka in order to reflect the recent changes to alpaka's CMake infrastructure. I noticed that all older alpaka releases are installable by uncommenting a few lines. However, these would collide with the new CMake based approach which should amount to essentially the following:

def cmake_args():
    args = ['-Dalpaka_BUILD_EXAMPLES=OFF', '-DBUILD_TESTING=OFF']

def setup_dependent_run_environment(self, spack_env, run_env, dependent_spec):
    spack_env.prepend_path('CMAKE_MODULE_PATH', self.prefix)

Do we still want to keep the older routines or can they be removed?

Sorry for the late reply.

Since it's only a few lines, you can add @when('@:up-to-last-old-version') decorators to functions or do spec.satisfies('@:up-to-last-old-version') in function bodies.

But since the primary consumer was PIConGPU which had shipped an internal copy of Alpaka, you can also remove the old versions here. The old install was a hack and once your new updates are merged herein and well-tested for some time, we can start to mainline the alpaka package into Spack upstream.