CompVis / metric-learning-divide-and-conquer

Source code for the paper "Divide and Conquer the Embedding Space for Metric Learning", CVPR 2019

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Symbol ')' is placed in the wrong location

jinzhao1522 opened this issue · comments

Hi:
In sample function, I may have found a small mistake. Code in
https://github.com/CompVis/metric-learning-divide-and-conquer/blob/master/lib/data/loader/sampler.py#L59

Maybe you meaning is

replace = len(self.C_index[class_]) < self.num_samples_per_class

Symbol ')' is placed in the wrong location.

Thank you for your public code!

Hi,

Thank you. Yes, it's a small bug. You can fix it, but it doesn't actually change much.

Best,
Artsiom

@jinzhao1522 您好 我目前在从事相关的研究,想和您交流一下这个程序可以吗,我的联系方式qq:1747899323 wechat:gdz1747899323