CommunityOfCoders / COCWebsite

The official website of Community Of Coders, VJTI.

Home Page:https://www.communityofcoders.in

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove Some External Stylesheet Links

akshatshah21 opened this issue · comments

In new_client/public/index.html, there are some <link> tags that link to CDN stylesheets and fonts:

<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css">
<link rel=stylesheet href=https://cdn.jsdelivr.net/npm/@mdi/font@latest/css/materialdesignicons.min.css>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<!-- Fonts -->
<link href="https://fonts.googleapis.com/css?family=Roboto:300,400,500,700&display=swap" rel="stylesheet">
<link href="https://fonts.googleapis.com/css2?family=Titillium+Web:wght@700&display=swap" rel="stylesheet">

Fonts can be placed in new_client/src/components/assets, just like Recharge Bold is already there. This might speed up loading.

Also, there's already the @material-ui/icons dependency for icons, so Material Design Icons and Font Awesome links can be removed after changing all usages.

Nice catch, it looks to me that out of these CDNs, we genuinely require only Roboto. Since we have Material Icons already, both of the CDNs can actually be removed after replacing content.