Comcast / jrugged

A Java libary of robustness design patterns

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

RolledUpMonitoredStatus getReasons() is ambiguous

weggert opened this issue · comments

If a RolledUpMonitoredService has a status that is not UP then getReasons can be used to determine the cause. Calling getReasons() enumerates the reason for each child service that is not UP. In many cases the child services are CircuitBreakers.

The current behavior for getReasons() lists only 'Open' or 'Send Probe Request' for each CircuitBreaker. It does not include any identification for which CircuitBreaker is affected.

It would be better to add the service name as a prefix for each reason, making it clear which service is causing the Non-UP status for the RolledUpMonitoredService.

Before Change: getReasons() might return
{ "Open", "Send Probe Request" }

After Chnage: getReasons() might return
{ "Service 1:Open", "Service 2:Send Probe Request" }

Closing with the pull request from issue 16.