[BUG] push-menu.ts uses 'touchstart' in non-passive mode
WalterB-MAMC opened this issue · comments
Walter Burditt commented
The developer console reports the push-menu.ts
files uses of touchstart
as an issue as it does not allow for passive mode. This is a scroll-blocking event and makes the page less responsive. It needs {passive: true}
to be added to the event listener like the following:
sidebarOverlay.addEventListener('touchstart', '{passive: true}', event => {
event.preventDefault()
const target = event.currentTarget as HTMLElement
const data = new PushMenu(target, Defaults)
data.collapse()
})
More details on this can be found here
Daniel commented
Please Create PR for this
Walter Burditt commented
The PR #5583 has been created for this issue. I accidently submitted this issue with my work account.