Would it be possible to add support for AWS?

Question

Would it be possible to add support for AWS?

martinka opened this issue 4 years ago · comments

Michael E. Martinka commented 4 years ago

I am looking at using httpx and I like what you have done to add support for authentication to it here. I was wondering if you would be open to me working on and submitting a PR to add aws4auth?

Colin Bounouar · Answer 1 · Thu May 21 2020 04:51:34 GMT+0800 (China Standard Time)

Yes of course go ahead !

Michael E. Martinka · Answer 2 · Fri May 22 2020 03:37:21 GMT+0800 (China Standard Time)

One follow up.. its pretty involved... not quite as bad as OAuth but not nothing. do you want me to put it all in the authentication.py or should I split it out into its own file. Or keep a minimal Class in the authentication file and put "helper functions" in a separate file?

Colin Bounouar · Answer 3 · Fri May 22 2020 04:00:03 GMT+0800 (China Standard Time)

I guess you can put it in a dedicated file :-)

…

On Thu, May 21, 2020, 21:37 Michael E. Martinka ***@***.***> wrote: One follow up.. its pretty involved... not quite as bad as OAuth but not nothing. do you want me to put it all in the authentication.py or should I split it out into its own file. Or keep a minimal Class in the authentication file and put "helper functions" in a separate file? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZ5P7LPKSDOIETRFHILLPDRSV7H7ANCNFSM4NGGNN3Q> .