Col-E / Recaf

The modern Java bytecode editor

Home Page:https://coley.software/Recaf/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Tiny v1 mapping don't work

sheng-ri opened this issue · comments

Describe the bug

We can get tiny map from here
Tiny Mapping Doesn't work.
In dev4 latest version.

To Reproduce

Steps to reproduce the behavior:

  1. Open any fabric mod(1.20.4)
  2. Using Mapping->Apply->Tiny-V1
  3. Nothing Happened

Exception

None

Screenshots

None

Did I do anything wrong

I found tiny format is different in

public class TinyV1Mappings extends AbstractMappingFileFormat {

commented

Which jar file did you use, and which mappings file did you use?
I need a sample that reproduces the problem.

commented

Accidentally closed, was writing a comment for a separate ticket, oops

commented

Looks like the current implementation we have was based on the layout of v1 intermediary named but these are v1 official intermediary named which results in official -> intermediary

commented

Addressed in 0fa3551

Be aware that due to the structure of some mixins, not all classes will be renamed since Recaf isn't aware of @Mixin(TargetClass.class) implying that this extends/implements TargetClass. But that is a separate issue from the format parser.