Monaco actions didn't works with keybinding service override

[Dmitriy Yurov]

Hi Team!

I have a lot of custom actions for monaco-editor, they all registered after initialisation process via createConfiguredEditor call.
And after that al actions didn't works, just ignoring by editor. What i do wrong?

[Dmitriy Yurov]

init services looks like this:

await monacoLsp.initServices({
	userServices: {
		...modelService.default(),
		...keybindingService.default(),
		...configurationService.default(workspaceUri),
	},
});

[Loïc Mangeonjean]

can you provide a minimal reproduction code ?

[Dmitriy Yurov]

Do you have a ready demo stand with basic configuration which can help me start working on it?

[Loïc Mangeonjean]

isn't the demo here enough?

[Dmitriy Yurov]

import getKeybindingsServiceOverride, { initUserKeybindings } from '@codingame/monaco-vscode-keybindings-service-override'

I am looking at the demo, and didn't see initUserKeybindings method in published npm of monaco-vscode-keybindings-service-override

[Dmitriy Yurov]

I am using editor.addAction to register custom actions, and i see my actions in command palette and context menu, but it isnt called by keyboard shorcuts.

[Loïc Mangeonjean]

initUserKeybindings is a brand new method that should be available in the very last version

[Dmitriy Yurov]

Should i use updateUserKeybindings to pass action calls? Like you do with initUserKeybindings

[Loïc Mangeonjean]

Those 2 methods only allows to update the user keybinding configuration file, like you can do in vscode, it can add new commands

[Dmitriy Yurov]

But why it didnt works out of the box? I mean via editor.addAction

[Loïc Mangeonjean]

It seems to be a regression, the fix is in #246

[Loïc Mangeonjean]

Do you confirm the fix?

[Dmitriy Yurov]

Not able to build project, packages issues, i am waiting until language client will be released, i let you know

[Kai Salmen]

Not able to build project, packages issues, i am waiting until language client will be released, i let you know

7.0.2 is available

[Dmitriy Yurov]

Thanks for the notification about release. Looks much better, working well