Create favicon

Question

Create favicon

niccokunzmann opened this issue 7 years ago · comments

Nicco Kunzmann commented 7 years ago

Website-link: https://coderdojopotsdam.github.io/regex-tutorial

Expected Behavior

I would like to see a favicon in the browser menu.

Actual Behavior

There is no icon, yet.

Actions to Reproduce

Solution Description

We could use

a regular expression icon (is there one?) or
the CoderDojo Potsdam favicon https://github.com/CoderDojoPotsdam/organize/tree/master/logo

The favicon should also be used on the redirect pages.

Hints

HTML pages can set the favicon with a tag in the head.

Hamel Desai · Answer 1 · Tue Apr 18 2017 21:56:04 GMT+0800 (China Standard Time)

Hello I am new to open source can I work on this?

Nicco Kunzmann · Answer 2 · Tue Apr 18 2017 22:10:07 GMT+0800 (China Standard Time)

Hi, welcome! Yes, you can! Let me know if you need help or you like it more specific.

Christopher Rizzo · Answer 3 · Wed Apr 19 2017 02:37:01 GMT+0800 (China Standard Time)

I'll leave this one for @hd719, but got anything else for a first PR that you could need help with @niccokunzmann ?

Nicco Kunzmann · Answer 4 · Wed Apr 19 2017 06:48:27 GMT+0800 (China Standard Time)

@Crizzooo #7 is CSS only
#9 is putting a number into the current bubble one is working on, like in https://studio.code.org/s/mc/stage/1/puzzle/1 (Jekyll+CSS+HTML)
In #13 You can discuss with us what would be a good way to translate this into different languages and manage the different translations.
Let me know if you have any questions. You can also comment in the issues you are interested in.

Hamel Desai · Answer 5 · Tue May 02 2017 03:37:56 GMT+0800 (China Standard Time)

Hey @niccokunzmann so I think I added the favicon to all the pages, but how would I test it out?

-Thank you.

Nicco Kunzmann · Answer 6 · Tue May 02 2017 04:37:21 GMT+0800 (China Standard Time)

@Crizzooo You can install Jekyll and run jekyll serve --trace to see the website at http://localhost:4000

If you like, you can add your learnings to a CONTRIBUTING.md file, so other have a quicker start.

Let me know it I can help you.

Hamel Desai · Answer 7 · Tue May 02 2017 04:58:47 GMT+0800 (China Standard Time)

Alright cool i'll install Jekyll.
Also @niccokunzmann what do you mean by learnings?

Nicco Kunzmann · Answer 8 · Tue May 02 2017 05:30:31 GMT+0800 (China Standard Time)

learnings = Everything that could help other developers.

Nicco Kunzmann · Answer 9 · Tue May 02 2017 06:01:04 GMT+0800 (China Standard Time)

@hd719 The link is there but it does not show up.

I guess it is a path issue.
I will go to sleep now. Have a nice time, whereever you are :)

Hamel Desai · Answer 10 · Tue May 02 2017 06:06:06 GMT+0800 (China Standard Time)

Try clearing your browser history.

Nicco Kunzmann · Answer 11 · Tue May 02 2017 15:42:39 GMT+0800 (China Standard Time)

Can you see the favicon here? https://github.com/CoderDojoPotsdam/regex-tutorial

Nicco Kunzmann · Answer 12 · Tue May 02 2017 16:11:17 GMT+0800 (China Standard Time)

I tried ../favicon.ico and it is visible!

Nicco Kunzmann · Answer 13 · Tue May 02 2017 16:11:48 GMT+0800 (China Standard Time)

Nicco Kunzmann commented 7 years ago

Hamel Desai · Answer 14 · Tue May 02 2017 20:45:52 GMT+0800 (China Standard Time)

Hey @niccokunzmann I tried ../favicon.ico and it worked for me as well do you want me to change it?