Codeinwp / neve

A fast, lightweight, AMP ready WordPress theme built with speed and usability in mind.

Home Page:https://themeisle.com/themes/neve/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dropdowns (input select) in specific widgets do not respect global form styles

JohnPixle opened this issue ยท comments

Description:

We can see this example in the footer of this page.

Notice how the Posts archive widget and the Product categories archives do not follow the global form styles, while the categories archive dropdown in the middle does.

Screenshot 2021-02-23 at 14 22 45

I have found these widgets with dropdown options:

  • Post Archives
  • Categories Archives
  • Product Archives
  • Product Categories Archives

In our future integrations with other expert platforms (EDD, LearnDash etc), we should keep an eye on any custom widgets that provide dropdown view options.

cc @selul

Alternatives:

@JohnPixle @selul I agree that Archives should be the same as Categories but the Product Archives widget is using a select2 input added in WooCommerce. I tried to make it work for that input too but all I could get is https://prnt.sc/11pcyfz.

A select2 transforms a select field from

<select ....

to

<select style="display:none"...
<div class="select2"
<div class="select2 wrapper"
<div class="select2 input wrapper"
...
</div>
</div>
</div> 

I had a look and other themes are not adding any style for it and I would suggest doing the same. Let me know your thoughts.

@JohnPixle just a quick note to keep you in the loop. After today's dev meeting we agreed that we shouldn't modify the select field that I told you about, the one from the WooCommerce widget.

as a follow-up note to explain the decision, since the selects are not cored HTML selects and they are using a custom format, we choose to not style those for now.

Hey, thanks for the intel here @selul and @cristian-ungureanu, makes sense not to style them.

๐ŸŽ‰ This issue has been resolved in version 2.11.2 ๐ŸŽ‰

The release is available on GitHub release

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€