when building onesignal_app_id is changing in module also.
vivekb91 opened this issue · comments
we need to change the placeholders in build folder project only. But for onesignal values are changing module files also.
I will check for other modules also.
it is not happening for other modules. I think other modules wont have placeholders in gradleapp file.
We are going to link project instead of copying. In this case I think it will not work.
#51
Please let me know you ideas
I didn't understand the issue when we start linking the project instead of copying. Can you explain why please ?
I suppose we should start linking after issue 51 completed
#51
If the issue 51 is completed, then this issue is irrelevant.
But the gradle.xsl files no need to change, right ?
@CodeCombiner currently we are changing the values on xsl file and copying that to main gradle file. We can change the placeholders while copying or after. we don't need to change the value in xsl file. for other plugins it working fine I guess, for onesignal only this issue happening.
I will make updates for this.
@rampr @CodeCombiner I will check