util plugin manifest.xsl error
vivekb91 opened this issue · comments
INSTALL_STORE value have a unwanted space.
Do you mean this?
<meta-data android:name="INSTALL_STORE" android:value="\ android"/>
It seems that all of metadata includes \
@rampr please confirm extra spaces are not required or were absent previously because they are applied to all variables during xsl transformation.
@CodeCombiner previously also the meta data was like this only.
but when we are calling meta.get("INSTALL_STORE").toString(). no white space was coming. but on the new version white is coming. I added logs at the same place for older version and the latest one. But this is the observation.
I am not sure why older version have that space.
There used to be an issue where numbers were not considered as strings and hence we added space in the xsl(stylesheet file). Maybe it isn't needed anymore.
Example commit where it was first done.
play-co/facebook@845c097#diff-95a23de91ffc66f5664883c8296a32bf
The issue is happening in some version of linux only. I will verify this. closing for now and once verified and needed i will reopen.
This is wrong observation. it is happening in mac also.
Removed whitespace
hashcube/utils#18
This is not required any more and as it seems it is redundant because there are new methods added:
meta.get returns java Object
meta.getInt
meta.getDouble
meta.getString
We can remove empty spaces and backslashes during errors debugging or we can update all plugins at once. Please, open new issue if you want to do that.
We can create an issue and keep it low priority. I have no idea if it will break with the whitespace. We would have to test it out.