[plugins.json] Add cocoapods-dependency-graph
sueLan opened this issue · comments
Please add the following entry to the plugins.json
file:
{
"gem": "cocoapods-dependency-graph",
"name": "CocoaPods Dependency Graph",
"author": "Rongyan Zheng",
"url": "https://github.com/sueLan/cocoapods-dependency-graph",
"description": "A Cocoapods plugin to create the dependency graph and help you manage dependencies in your project."
}
Thanks for your contribution!
Just a few notes before we can merge this:
- The plugin doesn't appear to be on RubyGems. This would prevent most users from installing it. Please publish your gem to RubyGems.
- The Readme file lists that it has a dependency,
rgl
, but the.gemspec
doesn't list this dependency. This means that, even if it was published, the dependency won't be installed with it and the plugin wouldn't work. Please add the dependency to the.gemspec
. - It appears that the plugin outputs its graph on every run of
pod install
. This would incur a performance hit during the course of regular development. My suggestion is moving the graph output to a subcommand (there already seems to be a stub).
I also noticed that this isn't a PR but an Issue. Please create a PR to help us including your plugin.
Hi,
sorry for the late reply.
- The plugin doesn't appear to be on RubyGems. This would prevent most users from installing it. Please publish your gem to RubyGems.
- The Readme file lists that it has a dependency,
rgl
, but the .gemspec doesn't list this dependency. This means that, even if it was published, the dependency won't be installed with it and the plugin wouldn't work. Please add the dependency to the .gemspec.
- It appears that the plugin outputs its graph on every run of pod install. This would incur a performance hit during the course of regular development.
Yes. This plugin runs on every run of pod install
. I do it on purpose.
-
Usually, people run
pod install
for update the dependency pods. Using post-install helps people update the dependency graph automatically. -
Now, I use dependency_output to control the output format. Only one kind of output is generated. Besides, I use install_context to construct the graph. No extra efforts to analyze the
Podspec
for pods and their relationtionship. The time cost is about O(nlogn). I think it is acceptable
- My suggestion is moving the graph output to a subcommand (there already seems to be a stub).
Yes, It is a stub. I saw this plugin made a subcommand to generate the dependency graph. But in order to do so, it has to read the Podspec
file and analyze it, code. It is more time-consuming from the users perspective.