Clivern / Beaver

💨 A real time messaging system to build a scalable in-app notifications, multiplayer games, chat apps in web and mobile apps.

Home Page:https://clivern.github.io/Beaver/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Don't handle error when create file log

andrewvo148 opened this issue · comments

f, _ := os.Create(fmt.Sprintf("%s/gin.log", viper.GetString("log.path")))

If log.path doesn't exists it will silent failure, so i think should handle error.

commented

You are indeed right @andrewvo148, I should do panic in this case.
If you wanna update this, would be nice otherwise i will do that

@Clivern . I very happy to make it