Clinical-Genomics / cg

Glue between Clinical Genomics apps

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Alter the ordering of microbial samples

karlnyr opened this issue · comments

Description

We need to change the order form for microbial samples to align with other ordering logic, and make delivery of microbial sample data more logical for production members and customers. Thus, we need to create two types of microbial workflows, one where we do the typing and quality report - which requires customers to give us a reference, and one where we only sequence the microbial samples for the customers. After discussions with SVA, the current QC report is of little value, so diverging away from the current flow, and decoupling us a bit more from microSALT is a good decision. Further, with this logic, we would also be able to remove some strange delivery types tailored for only microSALT and change the microbial deliveries to use delivery types like fastq and analysis like other workflows.

Suggested solution

New microbial orders

New order: Sequencing of Microbial WGS - We do not require the customer to give the references of the samples. It would be similar to the Sequencing of clinical samples order. The difference is that the application tags in the Sequencing of Microbial WGS would include the MWR/MWX/VWR apptags. We are also adding new application tags in this project, so the orders must include them as allowed application tags.

New order: microSALT typing and quality report (sequencing/existing samples) - This is the same order as we have for Microbial WGS, but changing the name, and in the future, when we implement JASEN the swap will be more clear for customers.

Removal of delivery types

Remove the following delivery types from cg:

  • FASTQ_QC
  • FASTQ_QC_ANALYSIS

Change delivery types for microSALT

Change the delivery types available to microSALT to be:

  • ANALYSIS
  • ANALYSIS + FASTQ

This can be closed when

  • The customer can choose whether to analyse microbial samples or not when ordering.
  • Production only has one delivery option (analysis) for the microbial workflow

Blocked by

  • Analysis of VWG samples in microSALT, I am uncertain if they need the QC report. It is uncertain if they do care about it today. If they do, we would need to somehow make an order for microsalt, where either in the delivery or in the workflow, it is clear that we are to only care about the quality report.

Will add this to the refinement for 5th of June if approved in the LGM meeting on the 29th.

@karlnyr I believe the customers that order VWG samples look through the QC report!
I just handled a ticket of VWG samples where there was something wrong with attaching the QC report to the email and they wrote to us asking to send the file again - Ticket #324745.

Could we perhaps have the following delivery types? FASTQ, QC and MLST (or TYPING)
We could also keep ANALYSIS corresponding to QC, if it has any advantage with harmonising it with the rest of the pipelines.

That is not the way to go. I will talk with the customer ordering VWG, because the current analysis that we are offering them is shoehorned into their needs - we want to decouple ourselves from microSALT, and this is a way forward to that. The discussion on LGM is to go with delivery types ANALYSIS, and ANALYSIS + FASTQ, and then FASTQ as well, but when only FASTQ is ordered we do not run microSALT. Further, VWG will not be an option when ordering microSALT analysis.

Update: Customer does not even check the QC reports for VWG. We are a go!

Refinement 12-06-2024

Break up this issue into smaller work items with defined scope and outcome. @karlnyr and @Vince-janv

As previously mentioned there are two issues here:

  1. Microsalt delivery options are different than all other workflows. This creates confusion. Only Analysis an ANALYSIS + FASTQ should be available (same as for other workflows)
  2. Microbial samples should be able to be ordered as FASTQ orders. Currently this is only supported for human and metagenome samples.

I will create separate issues to track these

Split into:
#3339
#3338