Clinical-Genomics / cg

Glue between Clinical Genomics apps

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

CreateHandler add_<record> functions only return model

ChrOertlin opened this issue · comments

Description

In the store create handler the add_ (e.g. add_sample) only return a generated record but do not persist that to the database. This leads to that database sessions are accessed outsdie of the the CRUD layer.

We should encapsulate session handling in the store layer to decouple this code from the rest of cg.

Suggested solution

Write here if there is a suggested way to solve the issue

This can be closed when

Describe what needs to be done for this issue to be closed

Blocked by

If there are any blocking issues/prs/things in this or other repos. Please link to them.

Refinement

we acknowledge the problem and decide to improve over time.