NEXTFLOW_WORKFLOWS constant(s) while developping pipelines
rannick opened this issue · comments
Description
To avoid listing all the nextflow pipelines in the tests, a constant is defined. However while a new pipeline is added, not all tests should be executed
Suggested solution
i) Use two constants NEXTFLOW_WORKFLOWS_DEV and NEXTFLOW_WORKFLOWS
ii) Come back to a explicit list
iii) Adapt tests so they do not fail if a command is not yet implemented
At the moment i) is implemented (#3128)
This can be closed when
Solution i) is proving good enough or a decision is taken and implemented providing an alternative solution to the issue
Blocked by
What is it that happens, if a command is not fully implented? I thought that if a workflow command is added without subcommands, it should not fail any tests?
If the test executes the command but the command is not implemented, the test will fail
cg workflow jasen config-case funkitten
Usage: cg workflow jasen [OPTIONS] COMMAND [ARGS]...
Try 'cg workflow jasen --help' for help.
Error: No such command 'config-case'.
Great, thanks for the clarification!
But off arm my spontaneous reaction is that then either there is something wrong with how the tests are executed, or else with the strategy of iteratively adding pipelines.
I'm quite worried that having dev versions of constants is only making things more confusing.
I would personally advocate for something either being regarded as implemented, or not, although perhaps regarding different parts.
That is, I think if config-case is required for tests to go through, then we should not be allowed to merge until that is added? ... or the tests should be changed. Thats my 5c at least :)
But sure, if this is a way to get through the tests for now, from my side I'd say go ahead!
We went with this suggestion from HS at the end: #3128 (comment). Closing it!