Clinical-Genomics / cg

Glue between Clinical Genomics apps

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update LIMS API

ivadym opened this issue · comments

Description

The LIMS API hasn't been updated for a while, and it needs some attention since it doesn't follow the current coding guidelines.

Some of the issues we've identified so far:

  • Outdated methods and method names.
  • Interchangeable use of the LIMS API methods and sample object properties caused by poor type hinting (?).
  • Lack of constants to describe the UDF fields.

Review comments (#3153):

  • Do we still have anything in AM? Remove DocumentationMethod.AM support after checking with AL.
  • What's the PA1 constant? Can we make it a named variable?

Suggested solution

Address the issues pointed out above.

This can be closed when

  • LIMS API is up to date with our code practices.

Blocked by

If there are any blocking issues/prs/things in this or other repos. Please link to them.