Remove excess unit conversion logging to INFO from dodola.service
brews opened this issue · comments
We added automatic unit conversion in PR #143. This logs to INFO saying that unit conversion is happening for a variable.
It would be nice if we could drop those extra logging messages added to dodola.service from PR #143.
Instead we should put a logging message into dodola.core.xclim_units_any2pint and dodola.core.xclim_units_pint2cf, and be clear that a unit switch may happen, or maybe that it's converting cf units to paint units and vice-versa.
@brews I assigned this to myself. Let me know if you'd prefer to do it instead.
Naw, go for it, @emileten ! I appreciate the help. I'm happy to review the PR!
@brews how much of a priority is that for you ? So that I know where to put that in my todo list.
@emileten Low priority.
If you don't want to take it this week then I'd unassign yourself and someone else might pick it up.