Giters

ClementPinard / FlowNetPytorch

Pytorch implementation of FlowNet by Dosovitskiy et al.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

About rotation formula at the bottom of README.md

opened this issue · comments

commented

At the bottom of README.md, there is a formula for ratate function which I think has a little typo. I suppose the correct formula is:

rotate: x,y,theta ->  (x*cos(theta) - x*sin(theta), y*cos(theta) + x*sin(theta))

, where the second element of output is y*cos(theta) + x*sin(theta) rather than y*cos(theta), x*sin(theta).

Finally, thank you so much for this nice implementation of flownet !

commented

Hello, see how it has corrected here #99
so the whole formula needs to be updated, I'll try to fix this in the future.