addons breaks OAuth on services like Google/Amazon
nascentt opened this issue · comments
Love the addon, but after having google login broken for months i eventually tracked it down to clearurls and see people have been reporting it for a year in the reviews https://chrome.google.com/webstore/detail/clearurls/lckanjgmijmafbedllaakclkaicjfmnk
any chance for a fix?
Came here to say the exact same thing.
It took me a while to figure out that ClearURL was to blame.
Not seeing this issue with the Firefox extension. Google & Amazon login work as expected. Perhaps try disabling all extensions with the exception of ClearURLs to see if there is a possible negative interaction between ClearURLs and another extension.
Not seeing this issue with the Firefox extension. Google & Amazon login work as expected. Perhaps try disabling all extensions with the exception of ClearURLs to see if there is a possible negative interaction between ClearURLs and another extension.
It might be specific to the chrome version of the add-on.
It definitely occurs when ClearURLs is the only extension, so not a conflict
Not seeing this issue with the Firefox extension. Google & Amazon login work as expected. Perhaps try disabling all extensions with the exception of ClearURLs to see if there is a possible negative interaction between ClearURLs and another extension.
Not seeing this issue with the Firefox extension. Google & Amazon login work as expected. Perhaps try disabling all extensions with the exception of ClearURLs to see if there is a possible negative interaction between ClearURLs and another extension.
It might be a chrome only issue.
no have issue in firefox. it is extension issue, seems like extension also filter out essential attributes from https://accounts.google.com/signin/oauth/consent/approval
leaves those "?hl=en&_reqid=12345&rt=j"
Solution : Extension should exclude https://accounts.google.com/signin/oauth/ url from filtering
i think this is the issue :https://github.com/ClearURLs/Addon/blob/master/core_js/google_link_fix.js (file that handle all google links)
i am not sure but possible because after Oauth google redirects us
It took me a while to understand that it was due to this browser extension too. ^^"
Indeed, trying to authenticate to a 3rd party application with Google does not work. I get an error after selecting my Google account and approving.
Disabling the extension before approving solves the problem.
NB: sign-in to Google itself is not broken!
This has just started happening to me in Firefox, but only on certain Google OAuth flows. For example, Asana, Zoom, Zendesk, AWS SSO all work. Our own authentication system at work, which worked as recently as 23 January, has now started breaking when ClearURLs is enabled.
Any javascript devs able to submit a pull request? Sadly it looks like this has been abandoned and is breaking too many things that depend on OAuth in it's current state.
Hello there, i just created PR to fix this issue. It was not javascript bug but we had to add exception to rules.
Here PR at gitlab : 56
We can just wait for contributors to merge it(merged), until then you can use my repo rules.
Issue on using my rules : No hash file exists because i am lazy to run pipeline 🙇. So it will requests rules on each startup
Some problem i notice in extension while debugging it :
- After url is cleaned, it will change "%20" to " "(space), return and use decoded url
- I am not sure but i notice all special charactor code which starts with %, are decoded in cleaned url not just space? It can cause issue with corrupting legit attributes (ig it was doing this with google oauth)
Not seeing this issue with the Firefox extension. Google & Amazon login work as expected. Perhaps try disabling all extensions with the exception of ClearURLs to see if there is a possible negative interaction between ClearURLs and another extension.
Not seeing this issue with the Firefox extension. Google & Amazon login work as expected. Perhaps try disabling all extensions with the exception of ClearURLs to see if there is a possible negative interaction between ClearURLs and another extension.
It might be a chrome only issue.
no have issue in firefox. it is extension issue, seems like extension also filter out essential attributes from https://accounts.google.com/signin/oauth/consent/approval
leaves those "?hl=en&_reqid=12345&rt=j"
Solution : Extension should exclude https://accounts.google.com/signin/oauth/ url from filtering
Exceptions i added for google based filter:
https://accounts.google.com/o/oauth/
https://accounts.google.com/signin/oauth/
And for Global filters :
https://accounts.google.com/
Issue on using my rules : No hash file exists because i am lazy to run pipeline 🙇. So it will requests rules on each startup
To be honest, i am not able to run jobs on gitlab and gitlab UI is confusing for me
Any javascript devs able to submit a pull request? Sadly it looks like this has been abandoned and is breaking too many things that depend on OAuth in it's current state.
last comment : sorry i was busy at that time due to exams and other work.
Any javascript devs able to submit a pull request? Sadly it looks like this has been abandoned and is breaking too many things that depend on OAuth in it's current state.
last comment : sorry i was busy at that time due to exams and other work.
No worries! We all have lives. Thanks for the pr.
Some problem i notice in extension while debugging it :
- After url is cleaned, it will change "%20" to " "(space), return and use decoded url
- I am not sure but i notice all special charactor code which starts with %, are decoded in cleaned url not just space? It can cause issue with corrupting legit attributes (ig it was doing this with google oauth)
Oh wow. This sounds like it deserves it's own GitHub issue.
