ClaudiaRojasSoto / toDo_list

This exercise builds a simple to-do list using WebPack and then serving it with Webpack dev server.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Styles inside html on index.js

ClaudiaRojasSoto opened this issue · comments

I think it's an excellent job, with a well-kept code that clearly meets the objective, however, I found something that you can improve: Avoid mixing styles inline and in CSS files:
You mix inline styles with styles defined in the
style.css file. It is recommended to keep all the styles in the CSS file for better organization and maintenance.
For example, in the index.js file, you can remove the inline style lines within the innerHTML of the list item creation and move those rules to the style.css file.

<i class="fas fa-trash-alt" style="display:none"></i>

@ClaudiaRojasSoto