cwd display reworking
Ckath opened this issue · comments
these get cut off from the beginning, incorrectly. ideally they'd be given a longer space to fit in, or at the very least cut them of correctly at the end. this happens at some sizes and not at others
path shown correctly, see Unconnected
path shown incorrectly, see Unconnecte
possible solution started in cwd_displaying 04139dd which implements the solution of using a seperate 'window' to allow cwd to span multiple lines:
there are some issues regarding text cutoffs due to the order at which the windows get drawn, which might be fixable. to clarify this would still not fix the ever so slight difference with some sizes working and others just being one char off, since thats due to the bad handling of wide chars. but with the full width of the window these edgecases would appear less.
it seems the cutoff of characters is something magical, it doesnt happen in all terminals, sometimes it does seem to get printed correctly, and even when trying to force the cwd window to be drawn last it refuses to fix the issue. so I'm letting that part be, cwd spanning both windows is an edgecase at best anyways.
I did 'fix' widechar(moonrunes) handling in 04e5729, if it stays okay I'll merge and call it good enough