Window offset on 49' screens

Question

Window offset on 49' screens

ibigbug opened this issue 2 years ago · comments

Yuwei Ba commented 2 years ago

Describe the bug
The window is misplaced on large screen with scaling.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
The window should be centered or movable

Screenshots

Active DLCs
No

Active mods
No

Versions
Type /version into the in-game chat and paste the version numbers here:

Mod version: latest
Game version: latest

Additional context
Add any other context about the problem here.

Zombiextreme · Answer 1 · Thu Apr 21 2022 17:14:57 GMT+0800 (China Standard Time)

i would like to say that a 49 ft monitor would be fucking huge. i would suggest not using a cinema to play games.../s
but honestly. have you tried going through your settings and changing the display size? seems to be a game issue and not an issue with the mod itself.

Eld0r · Answer 2 · Thu Apr 21 2022 17:50:18 GMT+0800 (China Standard Time)

You might use that on "small" gaming 4k monitors as well to be able to read. the thing is that windows scaling % stuff regardless of size and resolution fucks up the position placement. because calling the resolution function returns actual screen resolution in screen pixels but the placement is done with the windows % scaling stuff. for example 1920*1080 screen resolution:when you place something at pos 1920/2 with scaling it uses 960 but will show at screen position 1440 (with 150% windows scaling, or exactly at the edge when using 200%) but all functions for placement can stay untouched when the call for screen resolution applies the zoom correction after the return. for the example of 150% scaling on fullHD divide the return values by 1.50 and store 1280*810 for resolution. then all positioning will work again. I don't know the call for a function that returns that windows zoom scale shenanigans stuff and there might already be getVirtualScreebWidth/Height (don't quote me on that name) functions which already take that into account tho. Am 21.04.2022 11:15 schrieb Zombiextreme ***@***.***>: i would like to say that a 49 ft monitor would be fucking huge. i would suggest not using a cinema to play games.../s —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Yuwei Ba · Answer 3 · Thu Apr 21 2022 18:11:06 GMT+0800 (China Standard Time)

thank you guys.

looks like it requires some env setup to be able to build this project as there are some missing refs in VS.

but any pointers to code change/build steps on top of https://github.com/CitiesSkylinesMultiplayer/CSM/wiki/Developer-Resources I'm happy to make a PR or help to test.

Yuwei Ba · Answer 4 · Thu Apr 21 2022 18:15:25 GMT+0800 (China Standard Time)

actually found this: https://skylines-modding-docs.readthedocs.io/en/latest/modding/Getting-Started/Setting-Up-Visual-Studio.html

now I can build

Yuwei Ba · Answer 5 · Thu Apr 21 2022 18:29:49 GMT+0800 (China Standard Time)

I seem to have fixed it on my machine.

Nico Borgsmüller · Answer 6 · Thu Apr 21 2022 21:44:32 GMT+0800 (China Standard Time)

Did the issue actually occur when using the latest version from master or our latest release? It should have already been fixed on the master branch some time ago, just not released yet.

Yuwei Ba · Answer 7 · Thu Apr 21 2022 22:00:50 GMT+0800 (China Standard Time)

@kaenganxt you're right, master branch is working fine already - didn't know there were unreleased changes there, will close this PR.