unicon HVRP self.config_prompt wrong regex
jibo78 opened this issue · comments
jibo78 commented
There is a regex mistake for hvrp's unicon patterns.py file
Path: myvenv/lib/python3.8/site-packages/unicon/plugins/hvrp/patterns.py
$ character is missing at the end of the regex self.config_prompt
self.config_prompt = r'^\[.*\]'
We have an error when we try to configure a Huawei N8000 device with pyATS
In [3]: device.configure(['interface GigabitEthernet0/7/2','shutdown'])
2022-09-29 14:46:16,117: %UNICON-INFO: +++ with via 'cli': config +++
system-view
Enter system view, return user view with return command.
[~N1-NE8000-PEAG-1]
---------------------------------------------------------------------------
TimeoutError Traceback (most recent call last)
TimeoutError: timeout occurred:
timeout value: 30
last_command: 'system-view\r'
pattern: ['^\\[.*\\]']
buffer:'system-view\r\nEnter system view, return user view with return command.\r\n[~N1-NE8000-PEAG-1]'
If we add $, it works
self.config_prompt = r'^\[.*\]$'
In [6]: device.configure(['interface GigabitEthernet0/7/2','shutdown'])
2022-09-29 14:29:03,854: %UNICON-INFO: +++ with via 'cli': config +++
system-view
Enter system view, return user view with return command.
[~N1-NE8000-PEAG-1]interface GigabitEthernet0/7/2
[~N1-NE8000-PEAG-1-GigabitEthernet0/7/2]shutdown
[*N1-NE8000-PEAG-1-GigabitEthernet0/7/2]commit
[~N1-NE8000-PEAG-1-GigabitEthernet0/7/2]return
<N1-NE8000-PEAG-1>
Taarini commented
Hi
Thanks for reporting.
Please consider contributing to the library.
Can you please create a PR to fix the issue.
Let me know if you create one, so that i can assist you with the approval
jibo78 commented
Hi Taarini,
I moved this issue to unicon repo:
CiscoTestAutomation/unicon.plugins#65
I will try to do a RP
Thanks for you help