Cinderella-Man / igthorn

Cryptocurrency trading platform

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rewrite tests as they fail in CI

Cinderella-Man opened this issue · comments

Currently all tests for naive trader are setting up whole environment(BinanceMock, DummyStreamer etc) and try to publish events that will cause some specific behaviour of Naive trading strategy (buy, sell, stop loss, rebuy, retarget etc.).

All those tests are working locally but as pointed above they require processes with state existing which means that they can't be run parallel.

Other sad fact is that they run completely fine locally but intermittently fail in CI.

Opportunity here would be to refactor tests (and possibly code) so they confirm expected behaviours but they don't rely on global state (processes etc)