Diffrent number of cards

Question

Diffrent number of cards

davidsoderberg opened this issue 7 years ago · comments

David Southmountain commented 7 years ago

Hi when I use Scryfall.Cards.search('s:' + 'kld').waitForAll().then, I got 439 cards for result.
But if I use https://api.scryfall.com/cards/search?q=s:kld, I get 264 cards for result. Should they not be the same number? I know I get duplicates and the have the same id from Scryfall. One example is "Key of the city".

Chiri Vulpes · Answer 1 · Thu Mar 15 2018 04:20:30 GMT+0800 (China Standard Time)

This sounds like a bug, but I'll have to look into it on my end. My job is a bit busy at the moment, so I'm not sure when I'll get to it. Hopefully within the week. Sorry for the wait!

David Southmountain · Answer 2 · Fri Mar 16 2018 21:54:55 GMT+0800 (China Standard Time)

I have made a reducer on my side to remove duplicates, looking on id from Scryfall. But yea a fix for this would be amazing 😄

Chiri Vulpes · Answer 3 · Sat Mar 17 2018 03:44:27 GMT+0800 (China Standard Time)

Fixed as of v1.0.2

Turns out the first page of the scryfall api is 1, not 0. Surprised I never noticed this. My tests weren't good enough!!