Pull Request comment "See the MS search here" link doesn't include usernames where appropriate
opened this issue · comments
Linked to this issue.
The opening comment that SmokeDetector makes on a Pull Request is sometimes incorrect as the "See the MS search here" link doesn't include usernames for watch and blacklist-keyword which can be confusing to reviewers.
The problem is happening on line 117 and 126 of gitmanager.py where &username_is_regex=1 is not set. &or_search=1 must also be set for accurate results.
I remember trying to fix this and it got rather long/complicated. Maybe a simple note: "Note: This search does not include usernames" is enough.
This issue has been closed because it has had no recent activity. If this is still important, please add another comment and find someone with write permissions to reopen the issue. Thank you for your contributions.