su-binary fails to compile using AOSP 4.1.1_r1 (LOGx API updated)

Question

su-binary fails to compile using AOSP 4.1.1_r1 (LOGx API updated)

r3n4ud opened this issue 12 years ago · comments

./system/core/include/cutils/log.h has changed in 4.1.1. When using su-binary in place of the bare system/extras/su, the compilation process failed on LOGx undefined errors.

git-core · Answer 1 · Sun Jul 22 2012 22:35:40 GMT+0800 (China Standard Time)

This issue has been fixed in the gc branch in slightly different way. See commit ffe8b01.
Considering your patch, it changes some parts that irrelevant of the issue. Did you make it intentionally?

Renaud Aubin · Answer 2 · Sun Jul 22 2012 23:02:47 GMT+0800 (China Standard Time)

OK, the gc branch fix is for the best, I'll use that. The irrelevant parts of the commit are due to my emacs-tabs-are-evil-before-save-hook settings ;)

I'll close the issue but why don't merge the gc branch jb fix in the master branch or make the gc the default branch or document what exactly are those branch (I have browsed gc-ics but it didn't seem intuitive to me to have to browse the gc branch to find jb support).

Anyway, thanks for your quick response!