LuminaSapphira / better-graves

A better gravestone mod for Minecraft + Fabric

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Inventory#dropAll overwrite may break mods' expectations

Pyrofab opened this issue · comments

The dropAll Overwrite will affect the behaviour of any mod that calls the method directly. It would probably be better to leave the original method intact and redirect the call in PlayerEntity#dropInventory instead.

Thanks for this~

Could you check to see if I used redirect appropriately (in a way that won't break other mods' expectations)? Thanks~~

Looks fine ! But I would recommend using At#target instead of At#ordinal to select the redirected method call. It would be less likely to break, and would make the code clearer.

Moved to using target, re-open if there's anything else I should change here