Strict Warning with GravatarHelper::url

Question

Strict Warning with GravatarHelper::url

Dunhamzzz opened this issue 12 years ago · comments

I've just got back to my project after a month or so off, and after upgrading CakePHP (I think this was the cause), I'm now getting a Strict warning on every page that uses the Gravatar helper:

Declaration of GravatarHelper::url() should be compatible with Helper::url($url = NULL, $full = false)

I'm not 100% sure how you'd want to patch this tbh, possibly use a different name for the method, or just hack the same parameters in?

Alejandro Ibarra · Answer 1 · Tue Sep 18 2012 20:17:56 GMT+0800 (China Standard Time)

Thank you @Dunhamzzz I will take a look.

Alejandro Ibarra · Answer 2 · Wed Sep 19 2012 19:09:55 GMT+0800 (China Standard Time)

@Dunhamzzz I cannot reproduce it. Can you specify Cake version and which branch are you using?

Matthew Dunham · Answer 3 · Wed Sep 19 2012 20:43:10 GMT+0800 (China Standard Time)

I am on the master branch with CakePHP v2.2.2

Just realised my dev environment is on PHP 5.4.4, when I switch to 5.3.14 it goes. So really it's not much of an issue bow but definitely something to keep tabs on.

Alejandro Ibarra · Answer 4 · Wed Sep 19 2012 22:39:29 GMT+0800 (China Standard Time)

Ok, I have 5.3.8 we will perform more tests over 5.4