Change ensure_future to create_task

Question

Change ensure_future to create_task

Cadair opened this issue 4 years ago · comments

Stuart Mumford commented 4 years ago

https://docs.python.org/3/library/asyncio-task.html#asyncio.create_task

we can do this because we are now 3.7+

Pradyumna Rahul · Answer 1 · Sat Dec 19 2020 00:52:36 GMT+0800 (China Standard Time)

Hey!
Can I be assigned this task?

Stuart Mumford · Answer 2 · Sat Dec 19 2020 01:01:21 GMT+0800 (China Standard Time)

You are welcome to work on it, I generally don't assign people to things though :)

Pradyumna Rahul · Answer 3 · Sat Dec 19 2020 01:05:02 GMT+0800 (China Standard Time)

Is assigning issues frowned upon? I was told the same in a previous issue

Pradyumna Rahul · Answer 4 · Sat Dec 19 2020 01:38:42 GMT+0800 (China Standard Time)

Hey I've made a PR #62

Stuart Mumford · Answer 5 · Sat Dec 19 2020 02:20:34 GMT+0800 (China Standard Time)

it's just a workflow choice some people and teams use it others don't. Sunpy and my personal repos generally don't unless there is a specific reason to.