Cadair / parfive

An asyncio based parallel file downloader for Python 3.8+

Home Page:https://parfive.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Timeouts don't work / invalid filename doesn't throw an exception / content-name not recognized

dreamflasher opened this issue · comments

As stated by the documentation downloads should timeout after 30 seconds, which they don't. For me they just never timeout. So I tried to add more timeouts to see if I can get any to work:

dl = Downloader(config=SessionConfig(timeouts=ClientTimeout(total=16, sock_read=16)))

But for this I have the same effect: Some downloads get stuck forever.

Maybe I am actually facing a different problem: I try to download this file: https://www.omnycontent.com/d/playlist/e73c998e-6e60-432f-8610-ae210140c5b1/f4e26994-3ddb-4ec7-b855-ae32006cd5de/ea4fae0c-3282-4cfd-b315-ae32006cd5ec/image.jpg?t=1650999093&size=Large and parfive gets stuck.

Because it gets stuck, I thought it's a timeout issue. But maybe the timeout works, but the file writing fails? When I try to download this file with download(filename=image.jpg) it works fine. So it looks like it fails because it tries to write filenames with illegal characters (Windows). That should throw an exception, but also the content-name is image.jpg so somehow that doesn't get recognized?

Could you try this with debug logging enabled?