Callback on download completion

Question

Callback on download completion

dreamflasher opened this issue 2 years ago · comments

It would be great to be able to pass a callback on download completion, ideally with the status of completion (succesful/error, source url, target path). That would for example enable me to implement #122 myself.

Marcel Ackermann · Answer 1 · Sat Jan 21 2023 02:51:39 GMT+0800 (China Standard Time)

I think this is relatively easy to implement, I am happy to do it, but at first mypy should be fixed in CI, so that I don't fix it in every new PR.

Marcel Ackermann · Answer 2 · Tue Mar 28 2023 19:19:35 GMT+0800 (China Standard Time)

I got the idea from: https://docs.python.org/3/library/asyncio-task.html#asyncio.Task.add_done_callback – but maybe there are not enough use cases in this project for that.

Marcel Ackermann · Answer 3 · Fri Apr 05 2024 00:08:40 GMT+0800 (China Standard Time)

Thanks a lot for merging!